Building with -sTEXTDECODER=2 when targeting -sAUDIO_WORKLET is not catastrophic #25347
+97
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Sep 22, 2025
…atastrophic since the user might very likely never attempt to interop any strings between JS and Wasm from the Audio Worklet thread. So leaving UTF8Decoder to be null there will be fine.
juj
force-pushed
the
wasm_audio_worklet_text_decoder_2
branch
from
4dd0167 to
c379a1e
Compare
Hmm that could be a separate PR. I am not completely sure about that. |
juj
force-pushed
the
wasm_audio_worklet_text_decoder_2
branch
from
9537730 to
c379a1e
Compare
sbc100
approved these changes
Oct 1, 2025
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (25) test expectation files were updated by running the tests with `--rebaseline`: ``` test/codesize/audio_worklet_wasm.expected.js updated codesize/test_codesize_cxx_ctors1.json: 149185 => 149179 [-6 bytes / -0.00%] codesize/test_codesize_cxx_ctors2.json: 148589 => 148583 [-6 bytes / -0.00%] codesize/test_codesize_cxx_except.json: 194602 => 194596 [-6 bytes / -0.00%] codesize/test_codesize_cxx_except_wasm.json: 164191 => 164185 [-6 bytes / -0.00%] codesize/test_codesize_cxx_except_wasm_legacy.json: 161780 => 161774 [-6 bytes / -0.00%] codesize/test_codesize_cxx_mangle.json: 258693 => 258687 [-6 bytes / -0.00%] codesize/test_codesize_cxx_noexcept.json: 151602 => 151596 [-6 bytes / -0.00%] codesize/test_codesize_cxx_wasmfs.json: 176862 => 176856 [-6 bytes / -0.00%] test/codesize/test_codesize_file_preload.expected.js updated codesize/test_codesize_file_preload.json: 24160 => 24154 [-6 bytes / -0.02%] codesize/test_codesize_files_js_fs.json: 18660 => 18654 [-6 bytes / -0.03%] codesize/test_codesize_files_wasmfs.json: 55706 => 55696 [-10 bytes / -0.02%] codesize/test_codesize_hello_O0.json: 38333 => 38325 [-8 bytes / -0.02%] codesize/test_codesize_hello_O1.json: 9028 => 9020 [-8 bytes / -0.09%] codesize/test_codesize_hello_O2.json: 6252 => 6246 [-6 bytes / -0.10%] codesize/test_codesize_hello_O3.json: 5948 => 5942 [-6 bytes / -0.10%] codesize/test_codesize_hello_Os.json: 5938 => 5932 [-6 bytes / -0.10%] codesize/test_codesize_hello_dylink.json: 45504 => 45498 [-6 bytes / -0.01%] codesize/test_codesize_hello_dylink_all.json: 843603 => 843605 [+2 bytes / +0.00%] codesize/test_codesize_hello_single_file.json: 6503 => 6497 [-6 bytes / -0.09%] codesize/test_codesize_hello_wasmfs.json: 5948 => 5942 [-6 bytes / -0.10%] codesize/test_minimal_runtime_code_size_audio_worklet.json: 5686 => 5680 [-6 bytes / -0.11%] codesize/test_small_js_flags.json: 2732 => 2726 [-6 bytes / -0.22%] codesize/test_unoptimized_code_size.json: 177911 => 177878 [-33 bytes / -0.02%] Average change: -0.05% (-0.22% - +0.00%) ```
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (3) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_cxx_mangle.json: 258687 => 258687 [+0 bytes / +0.00%] codesize/test_codesize_files_wasmfs.json: 55696 => 55700 [+4 bytes / +0.01%] codesize/test_codesize_hello_dylink_all.json: 843605 => 843597 [-8 bytes / -0.00%] Average change: +0.00% (-0.00% - +0.01%) ```
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (5) test expectation files were updated by running the tests with `--rebaseline`: ``` test/codesize/audio_worklet_wasm.expected.js updated codesize/test_codesize_cxx_mangle.json: 258687 => 258687 [+0 bytes / +0.00%] codesize/test_codesize_files_wasmfs.json: 55700 => 55696 [-4 bytes / -0.01%] codesize/test_codesize_hello_dylink_all.json: 843597 => 843605 [+8 bytes / +0.00%] codesize/test_minimal_runtime_code_size_audio_worklet.json: 5680 => 5929 [+249 bytes / +4.38%] Average change: +1.09% (-0.01% - +4.38%) ```
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (3) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_cxx_mangle.json: 258687 => 258687 [+0 bytes / +0.00%] codesize/test_codesize_files_wasmfs.json: 55696 => 55700 [+4 bytes / +0.01%] codesize/test_codesize_hello_dylink_all.json: 843605 => 843597 [-8 bytes / -0.00%] Average change: +0.00% (-0.00% - +0.01%) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building with -sTEXTDECODER=2 when targeting -sAUDIO_WORKLET is not catastrophic since the user might very likely never attempt to interop any strings between JS and Wasm from the Audio Worklet thread. So leaving UTF8Decoder to be null there will be fine.